[PATCH] D60439: [llvm-objcopy] Accept --long-option but not -long-option

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 10 04:16:24 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

The behaviour change looks good, in the sense that it does what you set out to do. I don't have any real objections to it aside from the fact that it is different from how LLVM tools typically work, but I personally also find it odd the LLVM tools work with a single-dash! I'd like others to comment on this though before giving the thumbs up, particularly @jakehehrlich as the code owner.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60439/new/

https://reviews.llvm.org/D60439





More information about the llvm-commits mailing list