[PATCH] D60439: [llvm-objcopy] Accept --long-option but not -long-option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: alexshap, jakehehrlich, jhenderson, rupprecht.
Herald added subscribers: llvm-commits, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

POSIX utilities accept one or more options without option-arguments
grouping together, e.g -pSx

Because llvm-{objcopy,strip} accept many short options (e.g. -p -S -x)
for compatibility with GNU objcopy as well as -long-option, there is
ambiguity if a long option starts with the character used by a short
option.

-long-option is uncommon and not used by people who expect both GNU
objcopy and llvm-objcopy to work. The UNIX utility convention and users'
expectation of command line parsing are strong enough. So, drop the
support for -long-option.


Repository:
  rL LLVM

https://reviews.llvm.org/D60439

Files:
  test/tools/llvm-objcopy/ELF/help-message.test
  test/tools/llvm-objcopy/ELF/objcopy-version.test
  test/tools/llvm-objcopy/ELF/strip-all.test
  test/tools/llvm-objcopy/ELF/strip-version.test
  tools/llvm-objcopy/ObjcopyOpts.td
  tools/llvm-objcopy/StripOpts.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60439.194243.patch
Type: text/x-patch
Size: 14764 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190409/dd9bad4e/attachment.bin>