[PATCH] D60367: [TableGen] Introduce !listsplat 'binary' operator

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 14:34:46 PDT 2019


javed.absar added a comment.

Thanks for this. Its good you show a use-case but probably the use case can be a separate commit.



================
Comment at: lib/TableGen/TGParser.cpp:1154
+              Error(OpLoc,
+                    Twine("expected output type to be a list, got type '") +
+                        ItemType->getAsString() + "'");
----------------
'output type' ? Would that be a bit confusing to user. I can't think of a better option though since the context (assignment?) won't be known.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60367/new/

https://reviews.llvm.org/D60367





More information about the llvm-commits mailing list