[PATCH] Add checks for MSVC in LLVM_FALLTHROUGH and LLVM_NODISCARD

Shoaib Meenai via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 14:32:19 PDT 2019


Could you submit this as a patch on Phabricator? It’ll get a lot more visibility that way. See https://llvm.org/docs/Phabricator.html

From: llvm-commits <llvm-commits-bounces at lists.llvm.org> on behalf of Thad House via llvm-commits <llvm-commits at lists.llvm.org>
Reply-To: Thad House <thadhouse1 at gmail.com>
Date: Tuesday, April 9, 2019 at 8:12 AM
To: "llvm-commits at lists.llvm.org" <llvm-commits at lists.llvm.org>
Subject: [PATCH] Add checks for MSVC in LLVM_FALLTHROUGH and LLVM_NODISCARD

MSVC defaults __cplusplus to an old version, which causes the preprocessor to fallthrough to the clang::xx attribute checks. MSVC see's these and errors intellisense. This checks for MSVC explicitly, and handles the attributes for it separately.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190409/b0f50965/attachment.html>


More information about the llvm-commits mailing list