[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

MyDeveloperDay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 00:25:53 PDT 2019


MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.


================
Comment at: clang/lib/Format/TokenAnnotator.h:114
+    // ensure its not `; <comment>`.
+    return !endsWith(tok::semi) && !endsWith(tok::semi, tok::comment);
   }
----------------
owenpan wrote:
> I think `endsWith()` ignores `tok::comment`, so
> ```
> return !endsWith(tok::semi);```
> should suffice?
I should ready the code comments more often! thanks, I'll update


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60363/new/

https://reviews.llvm.org/D60363





More information about the llvm-commits mailing list