[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

Owen Pan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 8 13:04:27 PDT 2019


owenpan added inline comments.


================
Comment at: clang/lib/Format/TokenAnnotator.h:114
+    // ensure its not `; <comment>`.
+    return !endsWith(tok::semi) && !endsWith(tok::semi, tok::comment);
   }
----------------
I think `endsWith()` ignores `tok::comment`, so
```
return !endsWith(tok::semi);```
should suffice?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60363/new/

https://reviews.llvm.org/D60363





More information about the llvm-commits mailing list