[PATCH] D59597: [scudo][standalone] Add flags & related parsers

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 8 12:38:55 PDT 2019


cryptoad updated this revision to Diff 194194.
cryptoad marked an inline comment as done.
cryptoad added a comment.

Following up on some good catches by Vitaly:

- changing the `isSeparator` code around to not be in the class
- adding a related function that also checks for null
- doing some inline initialization of the `FlagParser` members


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59597/new/

https://reviews.llvm.org/D59597

Files:
  lib/scudo/standalone/CMakeLists.txt
  lib/scudo/standalone/flags.cc
  lib/scudo/standalone/flags.h
  lib/scudo/standalone/flags.inc
  lib/scudo/standalone/flags_parser.cc
  lib/scudo/standalone/flags_parser.h
  lib/scudo/standalone/interface.h
  lib/scudo/standalone/tests/CMakeLists.txt
  lib/scudo/standalone/tests/flags_test.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59597.194194.patch
Type: text/x-patch
Size: 18793 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190408/874a6e50/attachment.bin>


More information about the llvm-commits mailing list