[PATCH] D59597: [scudo][standalone] Add flags & related parsers

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad marked 11 inline comments as done.
cryptoad added inline comments.


================
Comment at: lib/scudo/standalone/flags_parser.cc:48
+
+bool FlagParser::isSeparator(char C) {
+  return C == ' ' || C == ',' || C == ':' || C == '\n' || C == '\t' ||
----------------
vitalybuka wrote:
> Not sure why this is in header file.
> I'd hide as much as possible into
> namespace {} of cc file
> 
> BTW. cc is google3, llvm is cpp
Right, good point, remove it from the header!
As for the .cc vs .cpp, I am not sure why I started with that, and that's my bad. I will rename them all in a later CL.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59597/new/

https://reviews.llvm.org/D59597