[PATCH] D60367: [TableGen] Introduce !listsplat 'binary' operator

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 6 13:46:54 PDT 2019


lebedev.ri marked 2 inline comments as done.
lebedev.ri added inline comments.


================
Comment at: lib/Target/X86/X86ScheduleBdVer2.td:214
+                          !listsplat(1, !size(ExePorts)),
+                          Res))),
                     !add(UOps, LoadUOps)>;
----------------
craig.topper wrote:
> Doesn’t WriteRes already treat an empty list as 1 cycle per port?
The problem is that you can't concatenate an empty list (implied all-ones) with non-empty list here.
The result will be the non-empty list, and it won't match the length of the `ExePorts` list.



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60367/new/

https://reviews.llvm.org/D60367





More information about the llvm-commits mailing list