[PATCH] D60333: [X86][SSE] SimplifyDemandedBitsForTargetNode - Add PACKSS support
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 6 12:27:50 PDT 2019
RKSimon marked an inline comment as done.
RKSimon added inline comments.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:33513
+ case X86ISD::PACKSS:
+ // PACKSS saturates to -ve/+ve max integer value. So if we just want the
+ // sign bit then we can just ask for the source operands sign bit.
----------------
nikic wrote:
> What does `-ve/+ve` mean?
shorthand for negative and positive - I'll change the comment to INT_MIN/INT_MAX
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60333/new/
https://reviews.llvm.org/D60333
More information about the llvm-commits
mailing list