[PATCH] D60292: [AMDGPU] predicate and feature refactoring

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 5 11:02:40 PDT 2019


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPU.td:714-716
 def isVI : Predicate <
   "Subtarget->getGeneration() >= AMDGPUSubtarget::VOLCANIC_ISLANDS">,
   AssemblerPredicate<"FeatureGCN3Encoding">;
----------------
kzhuravl wrote:
> Should this be renamed at some point too?
Yes, but I want this to go from upstream and not the other way around. So a separate change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60292/new/

https://reviews.llvm.org/D60292





More information about the llvm-commits mailing list