[PATCH] D60292: [AMDGPU] predicate and feature refactoring

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 5 11:00:12 PDT 2019


kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.

LGTM. Minor comment which does not affect the LGTM! Thanks for doing this.



================
Comment at: lib/Target/AMDGPU/AMDGPU.td:714-716
 def isVI : Predicate <
   "Subtarget->getGeneration() >= AMDGPUSubtarget::VOLCANIC_ISLANDS">,
   AssemblerPredicate<"FeatureGCN3Encoding">;
----------------
Should this be renamed at some point too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60292/new/

https://reviews.llvm.org/D60292





More information about the llvm-commits mailing list