[PATCH] D60314: [DAGCombiner] Add missing flag to addressing mode check

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Probably better to put it inside the branches for ADD/SUB, to make it clear that it's those specific operations that have a base register?

Given the current places we call canFoldInAddressingMode, and that the relevant targets are missing HasBaseReg checks (in particular, I looked at ARM and AArch64), I imagine it would be very hard to reproduce any effective change, yes.  (Maybe you could come up with something for 32-bit ARM if you tried hard enough, but it's probably not worth bothering.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60314/new/

https://reviews.llvm.org/D60314