[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

Am I mistaken in that this effectively prevents the use of options to handle frameworks?  That really is a strong requirement and should be part of this patch.



================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:451
+  if (!ELFDependentLibs.empty()) {
+    auto *NMD = getModule().getOrInsertNamedMetadata("llvm.deplibs");
+    for (auto *MD : ELFDependentLibs)
----------------
I don't think its worth the shortening here, this is only going to be seen in the IR, so, lets spell it out (`llvm.dependent.libraries` or `llvm.dependent-libraries` sound good to me).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60274/new/

https://reviews.llvm.org/D60274