[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

[Peter Smith via Phabricator via llvm-commits]

peter.smith added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:841
                                         // for safe ICF.
+  SHT_LLVM_DEPLIBS = 0x6fff4c04,        // LLVM Dependent Library Specifiers.
   // Android's experimental support for SHT_RELR sections.
----------------
pcc wrote:
> peter.smith wrote:
> > This is the same value as has been proposed in another ELF extension in https://reviews.llvm.org/D60242 , May be worth coordinating here. It is probably worth us having a central place to document the LLVM specific ELF extensions as we are accumulating enough of them.
> I don't have any existing dependencies on the value that I've chosen. If Ben has no dependencies of his own, I reckon that whoever ends up committing first can just get this value, and the next person will get the next one. I think this can be our general policy.
> 
> Do you think that https://llvm.org/docs/Extensions.html#elf-dependent is not sufficient as a place to document our extensions?
I think it could be, now that I see it fully expanding with some of the extensions mentioning the elf terminology. I think we should mention the SHT_... and hex value so that someone doesn't have to dig for that in the source code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60274/new/

https://reviews.llvm.org/D60274