[PATCH] D60312: [llvm-readobj] Add GNU style dumper for .gnu.version_d section
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 5 02:49:54 PDT 2019
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3417
+ const uint8_t *SecStartAddress =
+ reinterpret_cast<const uint8_t *>(Obj->base() + Sec->sh_offset);
----------------
Given that much of this code is a copy of the LLVMStyle, that indicates that it should be shared somehow. I don't know if in this file, or in the Object library somewhere makes sense, but I think the only distinction should be how to print the output.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3453
+ if (Verdef->vd_cnt > 2)
+ report_fatal_error("more than one predecessor is not expected");
+
----------------
Higuoxing wrote:
> In `GNU readelf`, there's no limit on the number of predecessors. For example, if one symbol has more than one parents, `GNU readelf` will give:
>
> ```
> Parent 1: VERSION1
> Parent 2: VERSION0
> ...
> ```
>
> Shall we do the same thing in `llvm-readelf` ?
Is there a good reason to limit it? If not, I don't think we should. However, I get the feeling that this is a different patch, since we should do it in LLVM style too, unless there's a good reason not to.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60312/new/
https://reviews.llvm.org/D60312
More information about the llvm-commits
mailing list