[PATCH] D60312: [llvm-readobj] Add GNU style dumper for .gnu.version_d section

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 5 02:28:12 PDT 2019


Higuoxing marked an inline comment as done.
Higuoxing added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3453
+    if (Verdef->vd_cnt > 2)
+      report_fatal_error("more than one predecessor is not expected");
+
----------------
In `GNU readelf`, there's no limit on the number of predecessors. For example, if one symbol has more than one parents, `GNU readelf` will give:

```
Parent 1: VERSION1
Parent 2: VERSION0
...
```

Shall we do the same thing in `llvm-readelf` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60312/new/

https://reviews.llvm.org/D60312





More information about the llvm-commits mailing list