[PATCH] D60290: NFC: Move API uses of MD5::MD5Result to Optional
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 4 16:35:01 PDT 2019
echristo marked 2 inline comments as done.
echristo added inline comments.
================
Comment at: llvm/lib/MC/MCDwarf.cpp:364
if (EmitMD5) {
- MD5::MD5Result *Cksum = DwarfFile.Checksum;
+ const MD5::MD5Result &Cksum = DwarfFile.Checksum.getValue();
MCOS->EmitBinaryData(
----------------
dblaikie wrote:
> You can write this as "*DwarfFile.Checksum" rather than "DwarfFile.Checksum.getValue()" if you like. (I tend to prefer that)
>
>
SGTM. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60290/new/
https://reviews.llvm.org/D60290
More information about the llvm-commits
mailing list