[PATCH] D60290: NFC: Move API uses of MD5::MD5Result to Optional

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 4 16:25:52 PDT 2019


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good to me (:



================
Comment at: llvm/lib/MC/MCDwarf.cpp:364
   if (EmitMD5) {
-    MD5::MD5Result *Cksum = DwarfFile.Checksum;
+    const MD5::MD5Result &Cksum = DwarfFile.Checksum.getValue();
     MCOS->EmitBinaryData(
----------------
You can write this as "*DwarfFile.Checksum" rather than "DwarfFile.Checksum.getValue()" if you like. (I tend to prefer that)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60290/new/

https://reviews.llvm.org/D60290





More information about the llvm-commits mailing list