[PATCH] D60260: Match types of accumulator and result for llvm.experimental.vector.reduce.fadd/fmul

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 4 05:26:40 PDT 2019


sdesmalen created this revision.
sdesmalen added reviewers: RKSimon, aemerson, efriedma, spatel.
Herald added a subscriber: javed.absar.

The scalar start/accumulator value of the fadd- and fmul reduction
should match the result type of the reduction, as well as the vector
element-type of the input vector. Although this was not explicitly
specified in the LangRef, it was taken for granted in code implementing
the reductions. The patch also fixes the LangRef by adding this
constraint.


https://reviews.llvm.org/D60260

Files:
  docs/LangRef.rst
  include/llvm/IR/Intrinsics.td
  lib/IR/IRBuilder.cpp
  test/Assembler/invalid-vecreduce.ll
  test/CodeGen/AArch64/vecreduce-fadd.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60260.193691.patch
Type: text/x-patch
Size: 9670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190404/22593096/attachment-0001.bin>


More information about the llvm-commits mailing list