[PATCH] D60131: [ELF] Change default output section type to SHT_PROGBITS

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 06:31:32 PDT 2019


jakehehrlich added a comment.

This seems like the wrong fix to me. Shouldn't we be fixing the alignment bug with respect to segments not changing things like this?

If I recall correctly I made a change to make NOBITS the default because some sections nthat could have been NOBITS we're winding up as PROGBITS. I don't remember the exact details. I'm fairly sure this change regresses that point. You've changedna bunch of test from expecting NOBITS to expecting PROGBITS but that seems unjustified.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60131/new/

https://reviews.llvm.org/D60131





More information about the llvm-commits mailing list