[PATCH] D60131: [ELF] Change default output section type to SHT_PROGBITS

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 03:15:18 PDT 2019


andrewng marked an inline comment as done.
andrewng added a comment.

> I am not sure we have the practice to disable the test cases. What do you think about uploading the fix for orphan behavior
>  in a separate change rebased on this patch too, so that these 2 patches can be reviewed together?
>  (in that case, having XFAIL here is fine I think).

I'm still not 100% sure of the best approach for the other patch for the orphan behaviour. However, this fix is more important.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60131/new/

https://reviews.llvm.org/D60131





More information about the llvm-commits mailing list