[PATCH] D60137: Describe stack-id as an enum

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 09:41:28 PDT 2019


thegameg added a comment.

This is definitely nicer, thanks for working on it.

I have two concerns about this though:

- we're going from a target-specific "namespace" to a target-independent one, which means in this case that no other target can use the stack id 1
- we're exposing target-specific names and enums in the target-independent code


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60137/new/

https://reviews.llvm.org/D60137





More information about the llvm-commits mailing list