[PATCH] D59833: [FPEnv] New document for adding new constrained FP intrinsics

Fri Mar 29 14:21:18 PDT 2019

cameron.mcinally marked an inline comment as done.
cameron.mcinally added inline comments.

================
Comment at: docs/AddingConstrainedIntrinsics.rst:62
+version of the node does not use the chain then the STRICT node cannot
+either.::
+
----------------
andrew.w.kaylor wrote:
> I don't understand this last sentence. Our strict nodes do use the chain and the non-strict versions don't, right?
> 
> BTW, Craig tells me that we're probably going to have to rethink the who mutateStrictFPToFP think to keep instruction ordering correct. I'm not suggesting that you change that in this document now. Just mentioning it as something to think about.
> BTW, Craig tells me that we're probably going to have to rethink the who mutateStrictFPToFP think to keep instruction ordering correct. I'm not suggesting that you change that in this document now. Just mentioning it as something to think about.

Digressing a bit...

I also ran into problems with mutateStrictFPToFP and Custom lowerings in D54649.

Ideally mutateStrictFPToFP would go away once we have proper backend support. E.g. D55506. Although, I suppose it will take some time for all the backends to get up to speed, so mutateStrictFPToFP will have to live on for some time... :/

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59833/new/

https://reviews.llvm.org/D59833