[PATCH] D59833: [FPEnv] New document for adding new constrained FP intrinsics

Andy Kaylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 27 11:59:29 PDT 2019


andrew.w.kaylor added inline comments.


================
Comment at: docs/AddingConstrainedIntrinsics.rst:62
+version of the node does not use the chain then the STRICT node cannot
+either.::
+
----------------
I don't understand this last sentence. Our strict nodes do use the chain and the non-strict versions don't, right?

BTW, Craig tells me that we're probably going to have to rethink the who mutateStrictFPToFP think to keep instruction ordering correct. I'm not suggesting that you change that in this document now. Just mentioning it as something to think about.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59833/new/

https://reviews.llvm.org/D59833





More information about the llvm-commits mailing list