[PATCH] D59966: [MemorySSA] Don't optimize incomplete phis.
George Burgess IV via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 29 12:20:18 PDT 2019
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.
LGTM modulo one nit; thanks again!
================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:315
+ NewInsertedPHIs.push_back(MPhi);
+ NonOptPhis.insert(MPhi);
+ }
----------------
asbirlea wrote:
> george.burgess.iv wrote:
> > Should these be removed from `NonOptPhis` at some point later (e.g., around line 326)? Or is that done for us elsewhere?
> I believe it's removed in `fixupDefs()`.
> All phis added in the IDF are then moved to the `FixupList` and then `fixupDefs()` is called on them, where they should be "fixed" and removed from `NonOptPhis`.
Please add a comment to that effect here, then
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59966/new/
https://reviews.llvm.org/D59966
More information about the llvm-commits
mailing list