[PATCH] D59966: [MemorySSA] Don't optimize incomplete phis.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea marked 2 inline comments as done.
asbirlea added inline comments.


================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:315
+          NewInsertedPHIs.push_back(MPhi);
+          NonOptPhis.insert(MPhi);
+        }
----------------
george.burgess.iv wrote:
> Should these be removed from `NonOptPhis` at some point later (e.g., around line 326)? Or is that done for us elsewhere?
I believe it's removed in `fixupDefs()`.
All phis added in the IDF are then moved to the `FixupList` and then `fixupDefs()` is called on them, where they should be "fixed" and removed from `NonOptPhis`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59966/new/

https://reviews.llvm.org/D59966