[PATCH] D59964: [yaml2obj] Fixing opening empty yaml files.

[George Rimar via llvm-commits]

I think it is ok to have your patch as some kind of temporary solution for now perhaps (since it was already landed).

But I agree with Peter's comment that a problem is deeper and probably is inside the `yaml::Input` though.
So I posted a link to my old patch as a reference to show my attempt to fix that (since I patched `yaml::Input`? there).


Best regards,
George | Developer | Access Softek, Inc
________________________________
От: Puyan Lotfi <puyan.lotfi.llvm at gmail.com>
Отправлено: 29 марта 2019 г. 18:28
Кому: George Rimar via Phabricator; reviews+D59964+public+a77548a99b633ac3 at reviews.llvm.org
Копия: ah841814092 at gmail.com; chris.bieneman at me.com; compnerd at compnerd.org; George Rimar; llvm-commits at lists.llvm.org; puyan at puyan.org
Тема: Re: [PATCH] D59964: [yaml2obj] Fixing opening empty yaml files.

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.  If you suspect potential phishing or spam email, report it to ReportSpam at accesssoftek.com
Thank you for this! I can look into implementing a check for this in the yaml parser but for now I'd really like yaml2obj to not crash when I forget to pipe stderr to stdout. Does that sound reasonable?

PL

On Fri, Mar 29, 2019 at 2:45 AM George Rimar via Phabricator via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
grimar added a comment.

FYI: https://reviews.llvm.org/D38036


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59964/new/

https://reviews.llvm.org/D59964



_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190329/37165aac/attachment.html>