<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p></p>
<div>I think it is ok to have your patch as some kind of temporary solution for now perhaps (since it was already landed).<br>
</div>
<div><br>
</div>
<div>But I agree with Peter's comment that a problem is deeper and probably is inside the `yaml::Input` though.<br>
</div>
<div>So I posted a link to my old patch as a reference to show my attempt to fix that (since I patched <span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);">`yaml::Input`</span> there).<br>
</div>
<p><br>
</p>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div class="BodyFragment"><font size="2">
<div class="PlainText">Best regards,<br>
George | Developer | <span style="background-color:rgb(255,255,255); color:rgb(33,33,33); font-family:Calibri,sans-serif; font-size:13.3333px">Access Softek, Inc</span></div>
</font></div>
</div>
</div>
<div style="color: rgb(33, 33, 33);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>От:</b> Puyan Lotfi <puyan.lotfi.llvm@gmail.com><br>
<b>Отправлено:</b> 29 марта 2019 г. 18:28<br>
<b>Кому:</b> George Rimar via Phabricator; reviews+D59964+public+a77548a99b633ac3@reviews.llvm.org<br>
<b>Копия:</b> ah841814092@gmail.com; chris.bieneman@me.com; compnerd@compnerd.org; George Rimar; llvm-commits@lists.llvm.org; puyan@puyan.org<br>
<b>Тема:</b> Re: [PATCH] D59964: [yaml2obj] Fixing opening empty yaml files.</font>
<div> </div>
</div>
<div>
<div style="font-size:9pt; font-family:'Calibri',sans-serif">
<h3 style="background-color:#ffffff; font-size:10pt; border:1px dotted #003333; padding:.8em">
<span style="color:#ff6600">CAUTION:<strong> </strong></span>This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you suspect potential phishing or spam
email, report it to ReportSpam@accesssoftek.com</h3>
</div>
<div>
<div>
<div dir="auto">Thank you for this! I can look into implementing a check for this in the yaml parser but for now I’d really like yaml2obj to not crash when I forget to pipe stderr to stdout. Does that sound reasonable?</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">PL</div>
<div><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Mar 29, 2019 at 2:45 AM George Rimar via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
grimar added a comment.<br>
<br>
FYI: <a href="https://reviews.llvm.org/D38036" rel="noreferrer" target="_blank">https://reviews.llvm.org/D38036</a><br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D59964/new/" rel="noreferrer" target="_blank">
https://reviews.llvm.org/D59964/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D59964" rel="noreferrer" target="_blank">https://reviews.llvm.org/D59964</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</body>
</html>