[PATCH] D59952: [VPLAN] Remove option for stress testing.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 28 11:57:13 PDT 2019


fhahn added reviewers: sguggill, dcaballe.
fhahn added a comment.

Thanks Francesco. I think we can only remove the arbitrary picking of VF = 4 with VPlanStressTest. I think we still need the other parts for testing, to build VPlans for loops without the pragma, which are then not vectorized.



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:267
 
-// This flag enables the stress testing of the VPlan H-CFG construction in the
-// VPlan-native vectorization path. It must be used in conjuction with
----------------
Ok I think we still want to keep this one here, as it enables building VPlans for loops without the pragma. But we can remove the code to arbitrarily pick VF = 4.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6116
-    // For VPlan build stress testing, we bail out after VPlan construction.
-    if (VPlanBuildStressTest)
-      return VectorizationFactor::Disabled();
----------------
We still need this for correctness


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59952/new/

https://reviews.llvm.org/D59952





More information about the llvm-commits mailing list