[llvm] r357166 - - Addressed comments

[Xing GUO via llvm-commits]

Thank you, I got it, this is my first time use `git-svn`. I am sorry
about that.

Best Regards,
Xing



On Thu, Mar 28, 2019 at 8:52 PM Roman Lebedev <lebedev.ri at gmail.com> wrote:

> Please note that all these commits landed as-is, you need to manually
> squash them.
> Or, use `arc patch D<number>`, and that will get the whole patch with
> proper commit message.
>
> Roman.
>
> On Thu, Mar 28, 2019 at 3:50 PM Xing GUO via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> > Author: higuoxing
> > Date: Thu Mar 28 05:51:56 2019
> > New Revision: 357166
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=357166&view=rev
> > Log:
> > - Addressed comments
> >
> > Modified:
> >     llvm/trunk/tools/llvm-readobj/ELFDumper.cpp
> >
> > Modified: llvm/trunk/tools/llvm-readobj/ELFDumper.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/ELFDumper.cpp?rev=357166&r1=357165&r2=357166&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/tools/llvm-readobj/ELFDumper.cpp (original)
> > +++ llvm/trunk/tools/llvm-readobj/ELFDumper.cpp Thu Mar 28 05:51:56 2019
> > @@ -636,7 +636,7 @@ StringRef ELFDumper<ELFT>::getSymbolVers
> >    if (!dot_gnu_version_sec) {
> >      // No version table.
> >      IsDefault = false;
> > -    return StringRef("");
> > +    return "";
> >    }
> >
> >    // Determine the position in the symbol table of this entry.
> > @@ -675,7 +675,7 @@ StringRef ELFDumper<ELFT>::getSymbolVers
> >    if (VersionIndex == VER_NDX_LOCAL ||
> >        VersionIndex == VER_NDX_GLOBAL) {
> >      IsDefault = false;
> > -    return StringRef("");
> > +    return "";
> >    }
> >
> >    // Lookup this symbol in the version table.
> > @@ -696,7 +696,7 @@ StringRef ELFDumper<ELFT>::getSymbolVers
> >    }
> >    if (NameOffset >= StrTab.size())
> >      reportError("Invalid string offset");
> > -  return StringRef(StrTab.data() + NameOffset);
> > +  return StrTab.data() + NameOffset;
> >  }
> >
> >  template <typename ELFT>
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190328/242ee217/attachment.html>