<div dir="ltr">Thank you, I got it, this is my first time use `git-svn`. I am sorry about that.<div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr">Best Regards,<div>Xing</div><div><div><br></div></div></div></div></div></div></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 28, 2019 at 8:52 PM Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Please note that all these commits landed as-is, you need to manually<br>
squash them.<br>
Or, use `arc patch D<number>`, and that will get the whole patch with<br>
proper commit message.<br>
<br>
Roman.<br>
<br>
On Thu, Mar 28, 2019 at 3:50 PM Xing GUO via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: higuoxing<br>
> Date: Thu Mar 28 05:51:56 2019<br>
> New Revision: 357166<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=357166&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=357166&view=rev</a><br>
> Log:<br>
> - Addressed comments<br>
><br>
> Modified:<br>
>     llvm/trunk/tools/llvm-readobj/ELFDumper.cpp<br>
><br>
> Modified: llvm/trunk/tools/llvm-readobj/ELFDumper.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/ELFDumper.cpp?rev=357166&r1=357165&r2=357166&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/ELFDumper.cpp?rev=357166&r1=357165&r2=357166&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/tools/llvm-readobj/ELFDumper.cpp (original)<br>
> +++ llvm/trunk/tools/llvm-readobj/ELFDumper.cpp Thu Mar 28 05:51:56 2019<br>
> @@ -636,7 +636,7 @@ StringRef ELFDumper<ELFT>::getSymbolVers<br>
>    if (!dot_gnu_version_sec) {<br>
>      // No version table.<br>
>      IsDefault = false;<br>
> -    return StringRef("");<br>
> +    return "";<br>
>    }<br>
><br>
>    // Determine the position in the symbol table of this entry.<br>
> @@ -675,7 +675,7 @@ StringRef ELFDumper<ELFT>::getSymbolVers<br>
>    if (VersionIndex == VER_NDX_LOCAL ||<br>
>        VersionIndex == VER_NDX_GLOBAL) {<br>
>      IsDefault = false;<br>
> -    return StringRef("");<br>
> +    return "";<br>
>    }<br>
><br>
>    // Lookup this symbol in the version table.<br>
> @@ -696,7 +696,7 @@ StringRef ELFDumper<ELFT>::getSymbolVers<br>
>    }<br>
>    if (NameOffset >= StrTab.size())<br>
>      reportError("Invalid string offset");<br>
> -  return StringRef(StrTab.data() + NameOffset);<br>
> +  return StrTab.data() + NameOffset;<br>
>  }<br>
><br>
>  template <typename ELFT><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>