[PATCH] D59799: [wip][mips] Use AltOrders to prevent using odd FP-registers

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 27 15:27:27 PDT 2019


atanasyan updated this revision to Diff 192526.
atanasyan added a comment.

- Use more compact definitions of `AltOrders`
- Add comments

Thanks for pointing to the `MSA128WEvensRegClass`. I'm going to investigate a possibility to do the same trick with `AltOrders` in this case. If it's impossible, find the reason.
==================================================================================================================================================================================

Both GNU assembler and LLVM show warning if odd floating-point register appears in an asm file. As far as I understand the `-mno-odd-spreg` prevents using odd registers by backend, but does not prevent inserting such registers into asm file directly by a user.
====================================================================================================================================================================================================================================================================

1. Agreed, `FGRH32` looks redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59799/new/

https://reviews.llvm.org/D59799

Files:
  llvm/lib/Target/Mips/MipsRegisterBankInfo.cpp
  llvm/lib/Target/Mips/MipsRegisterInfo.cpp
  llvm/lib/Target/Mips/MipsRegisterInfo.td
  llvm/test/CodeGen/Mips/no-odd-spreg-msa.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59799.192526.patch
Type: text/x-patch
Size: 4856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190327/c8f6a20e/attachment.bin>


More information about the llvm-commits mailing list