[PATCH] D59853: MIR: Freeze reserved regs after parsing everything

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.

This LGTM with one comment.

Also I'm not sure if there is a way to avoid this kind of bugs in the future but maybe we want to at least make sure MFI is not depending on parsing the other bits.



================
Comment at: lib/CodeGen/MIRParser/MIRParser.cpp:430
+  // FIXME: This is a temporary workaround until the reserved registers can be
+  // serialized.
+  MachineRegisterInfo &MRI = MF.getRegInfo();
----------------
Can you add a comment on why this needs to be set after parsing the MFI?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59853/new/

https://reviews.llvm.org/D59853