[PATCH] D59385: [ARM] Don't try to create "push {r12, lr}" in Thumb1 at -Oz.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 12:14:44 PDT 2019


efriedma added a comment.

> When I tried your example it was pushing r7 and popping r3. I presume this is OK, providing r7 isn't modified?

Yes; the entire point of tryFoldSPUpdateIntoPushPop is to fold a stack adjustment into a preceding push, possibly using the "wrong" register, to save an instruction.

I'll post a new version with the test fixed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59385/new/

https://reviews.llvm.org/D59385





More information about the llvm-commits mailing list