[PATCH] D59385: [ARM] Don't try to create "push {r12, lr}" in Thumb1 at -Oz.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 03:07:37 PDT 2019


dmgreen added a reviewer: chill.
dmgreen added a comment.

I don't pretend to know a huge amount about the frame lowering code, but this looks fine to me.

When I tried your example it was pushing r7 and popping r3. I presume this is OK, providing r7 isn't modified?

There are now machine verifier checks for these illegal push/pops, right? Please add -verify-machineinstrs to the tests.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59385/new/

https://reviews.llvm.org/D59385





More information about the llvm-commits mailing list