[llvm] r356780 - Make clang-move use same file naming convention as other tools

Fri Mar 22 11:49:50 PDT 2019

Hello Nico,

This commit broke build step on the next builder:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/45690

. . .
FAILED:
tools/clang/tools/extra/unittests/clang-move/CMakeFiles/ClangMoveTests.dir/ClangMoveTests.cpp.o

/usr/bin/clang++  -DGTEST_HAS_RTTI=0 -DGTEST_HAS_TR1_TUPLE=0
-DGTEST_LANG_CXX11=1 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
-Itools/clang/tools/extra/unittests/clang-move
-I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/tools/extra/unittests/clang-move
-I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/include
-Itools/clang/include -Iinclude
-I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/include
-I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/tools/extra/clang-move
-I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang
-I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/utils/unittest/googletest/include
-I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/utils/unittest/googlemock/include
-std=c++11 -Wdocumentation -Wno-documentation-deprecated-sync -fPIC
-fvisibility-inlines-hidden -Werror=date-time
-Werror=unguarded-availability-new -std=c++11 -Wall -Wextra
-Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -pedantic -Wno-long-long
-Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type
-Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion
-fdiagnostics-color -ffunction-sections -fdata-sections -fno-common
-Woverloaded-virtual -Wno-nested-anon-types -O3    -UNDEBUG
-Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions
-fno-rtti -MD -MT
tools/clang/tools/extra/unittests/clang-move/CMakeFiles/ClangMoveTests.dir/ClangMoveTests.cpp.o
-MF
tools/clang/tools/extra/unittests/clang-move/CMakeFiles/ClangMoveTests.dir/ClangMoveTests.cpp.o.d
-o
tools/clang/tools/extra/unittests/clang-move/CMakeFiles/ClangMoveTests.dir/ClangMoveTests.cpp.o
-c
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/tools/extra/unittests/clang-move/ClangMoveTests.cpp
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/tools/extra/unittests/clang-move/ClangMoveTests.cpp:9:10:
fatal error: 'ClangMove.h' file not found
#include "ClangMove.h"

Please have a look?
The builder was already red and did not send any notifications.

Thanks

Galina

On Fri, Mar 22, 2019 at 9:33 AM Nico Weber via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: nico
> Date: Fri Mar 22 09:34:39 2019
> New Revision: 356780
>
> URL: http://llvm.org/viewvc/llvm-project?rev=356780&view=rev
> Log:
> Make clang-move use same file naming convention as other tools
>
> In all the other clang-foo tools, the main library file is called
> Foo.cpp and the file in the tool/ folder is called ClangFoo.cpp.
> Do this for clang-move too.
>
> No intended behavior change.
>
> Differential Revision: https://reviews.llvm.org/D59700
>
> Modified:
>     llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn
>
> llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn
>
> Modified:
> llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn?rev=356780&r1=356779&r2=356780&view=diff
>
> ==============================================================================
> --- llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn
> (original)
> +++ llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn
> Fri Mar 22 09:34:39 2019
> @@ -15,7 +15,7 @@ static_library("clang-move") {
>      "//llvm/lib/Support",
>    ]
>    sources = [
> -    "ClangMove.cpp",
> +    "Move.cpp",
>      "HelperDeclRefGraph.cpp",
>    ]
>  }
>
> Modified:
> llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn?rev=356780&r1=356779&r2=356780&view=diff
>
> ==============================================================================
> ---
> llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn
> (original)
> +++
> llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn
> Fri Mar 22 09:34:39 2019
> @@ -14,6 +14,6 @@ executable("clang-move") {
>    ]
>    include_dirs = [ ".." ]
>    sources = [
> -    "ClangMoveMain.cpp",
> +    "ClangMove.cpp",
>    ]
>  }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190322/1869bde1/attachment.html>