<div dir="ltr"><div dir="ltr"><span style="font-family:monospace,monospace">Hello Nico,<br><br>This commit broke build step on the next builder:<br><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/45690">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/45690</a><br><br>. . . <br>FAILED: tools/clang/tools/extra/unittests/clang-move/CMakeFiles/ClangMoveTests.dir/ClangMoveTests.cpp.o <br>/usr/bin/clang++  -DGTEST_HAS_RTTI=0 -DGTEST_HAS_TR1_TUPLE=0 -DGTEST_LANG_CXX11=1 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/extra/unittests/clang-move -I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/tools/extra/unittests/clang-move -I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/include -Itools/clang/include -Iinclude -I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/include -I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/tools/extra/clang-move -I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang -I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/utils/unittest/googletest/include -I/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/utils/unittest/googlemock/include -std=c++11 -Wdocumentation -Wno-documentation-deprecated-sync -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3    -UNDEBUG  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -fno-rtti -MD -MT tools/clang/tools/extra/unittests/clang-move/CMakeFiles/ClangMoveTests.dir/ClangMoveTests.cpp.o -MF tools/clang/tools/extra/unittests/clang-move/CMakeFiles/ClangMoveTests.dir/ClangMoveTests.cpp.o.d -o tools/clang/tools/extra/unittests/clang-move/CMakeFiles/ClangMoveTests.dir/ClangMoveTests.cpp.o -c /home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/tools/extra/unittests/clang-move/ClangMoveTests.cpp<br>/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/tools/clang/tools/extra/unittests/clang-move/ClangMoveTests.cpp:9:10: fatal error: 'ClangMove.h' file not found<br>#include "ClangMove.h"<br><br>Please have a look?<br>The builder was already red and did not send any notifications.<br><br>Thanks<br><br>Galina</span><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 22, 2019 at 9:33 AM Nico Weber via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: nico<br>
Date: Fri Mar 22 09:34:39 2019<br>
New Revision: 356780<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=356780&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=356780&view=rev</a><br>
Log:<br>
Make clang-move use same file naming convention as other tools<br>
<br>
In all the other clang-foo tools, the main library file is called<br>
Foo.cpp and the file in the tool/ folder is called ClangFoo.cpp.<br>
Do this for clang-move too.<br>
<br>
No intended behavior change.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D59700" rel="noreferrer" target="_blank">https://reviews.llvm.org/D59700</a><br>
<br>
Modified:<br>
    llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn<br>
    llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn<br>
<br>
Modified: llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn?rev=356780&r1=356779&r2=356780&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn?rev=356780&r1=356779&r2=356780&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn (original)<br>
+++ llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn Fri Mar 22 09:34:39 2019<br>
@@ -15,7 +15,7 @@ static_library("clang-move") {<br>
     "//llvm/lib/Support",<br>
   ]<br>
   sources = [<br>
-    "ClangMove.cpp",<br>
+    "Move.cpp",<br>
     "HelperDeclRefGraph.cpp",<br>
   ]<br>
 }<br>
<br>
Modified: llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn?rev=356780&r1=356779&r2=356780&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn?rev=356780&r1=356779&r2=356780&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn (original)<br>
+++ llvm/trunk/utils/gn/secondary/clang-tools-extra/clang-move/tool/BUILD.gn Fri Mar 22 09:34:39 2019<br>
@@ -14,6 +14,6 @@ executable("clang-move") {<br>
   ]<br>
   include_dirs = [ ".." ]<br>
   sources = [<br>
-    "ClangMoveMain.cpp",<br>
+    "ClangMove.cpp",<br>
   ]<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>