[PATCH] D59281: [WebAssembly] "atomics" feature requires shared memory

[Thomas Lively via Phabricator via llvm-commits]

tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: lld/wasm/Writer.cpp:915
+  if (TargetFeatures.count("atomics"))
+    Config->SharedMemory = true;
+
----------------
sbc100 wrote:
> I think we decided against this part right?    i.e. atomics should require but not imply shared memory?  So this should probably be an error instead.
Yes, sorry. I updated the name and description but I haven't updated the code yet. This CL is going to be blocked on an upcoming CL that detects whether any atomics were stripped. Landing that first will avoid unnecessary turn in some tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59281/new/

https://reviews.llvm.org/D59281