[PATCH] D59281: [WebAssembly] "atomics" feature requires shared memory
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 20 14:14:29 PDT 2019
sbc100 added inline comments.
================
Comment at: lld/wasm/Writer.cpp:915
+ if (TargetFeatures.count("atomics"))
+ Config->SharedMemory = true;
+
----------------
I think we decided against this part right? i.e. atomics should require but not imply shared memory? So this should probably be an error instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59281/new/
https://reviews.llvm.org/D59281
More information about the llvm-commits
mailing list