[PATCH] D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]

[Sterling Augustine via Phabricator via llvm-commits]

saugustine marked 4 inline comments as done.
saugustine added inline comments.


================
Comment at: clang/lib/Driver/ToolChain.cpp:695
+    if (RtLibType == ToolChain::RLT_CompilerRT)
+      return ToolChain::UNW_None;
+    else if (RtLibType == ToolChain::RLT_Libgcc)
----------------
MaskRay wrote:
> MaskRay wrote:
> > Is it `return ToolChain::UNW_CompilerRT;`?
> Sorry I didn't read the previous discussion :)
Just so that no one else needs to go back and read the previous discussion:

Current users of --rtlib=compiler-rt use a wide variety of platform specific methods of getting their libunwind symbols, and anything else breaks their build.

So the default when --rtlib=compiler-rt is no unwind library at all.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59109/new/

https://reviews.llvm.org/D59109