[PATCH] D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 22:33:54 PDT 2019


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/ToolChain.cpp:695
+    if (RtLibType == ToolChain::RLT_CompilerRT)
+      return ToolChain::UNW_None;
+    else if (RtLibType == ToolChain::RLT_Libgcc)
----------------
MaskRay wrote:
> Is it `return ToolChain::UNW_CompilerRT;`?
Sorry I didn't read the previous discussion :)


================
Comment at: clang/lib/Driver/ToolChain.cpp:702
+    return ToolChain::UNW_CompilerRT;
+  }
+  else if (LibName == "libgcc")
----------------
`} else if`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59109/new/

https://reviews.llvm.org/D59109





More information about the llvm-commits mailing list