[PATCH] D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local.

Tue Mar 19 08:53:56 PDT 2019

resistor marked an inline comment as done.
resistor added inline comments.

================
Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:21

-static ManagedStatic<
-    sys::ThreadLocal<const CrashRecoveryContextImpl> > CurrentContext;
+static const thread_local CrashRecoveryContextImpl *CurrentContext;

----------------
lebedev.ri wrote:
> Are you **sure** `thread_local` is fully supported by all the compilers that are supported for building LLVM?
> It wasn't supported by xcode for some time, maybe the newest version supports it though.
`thread_local` support was added in Xcode 8, in 2016:  https://asciiwwdc.com/2016/sessions/405#t=354.596

As far as I'm aware, all other supported compiler (GCC, MSVC) had thread_local support earlier than that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59443/new/

https://reviews.llvm.org/D59443