[PATCH] D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 14:02:16 PDT 2019


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:21
 
-static ManagedStatic<
-    sys::ThreadLocal<const CrashRecoveryContextImpl> > CurrentContext;
+static const thread_local CrashRecoveryContextImpl *CurrentContext;
 
----------------
Are you **sure** `thread_local` is fully supported by all the compilers that are supported for building LLVM?
It wasn't supported by xcode for some time, maybe the newest version supports it though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59443/new/

https://reviews.llvm.org/D59443





More information about the llvm-commits mailing list