[PATCH] D59543: [AMDGPU] Ban i8 min3 promotion.

Tue Mar 19 07:34:47 PDT 2019

arsenm added a comment.

The simple test reproduces the issue I would expect:
PromoteIntegerResult #0: t62: i8 = UMIN3 t66, t63, t59

Do not know how to promote this operator!
UNREACHABLE executed at ../lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:54

So the simple test seems fine

================
Comment at: test/CodeGen/AMDGPU/fmin3.ll:121-123
+; GCN-LABEL: {{^}}test_fmin3_olt_0_f64:
+; GCN-NOT: v_min3
+define amdgpu_kernel void @test_fmin3_olt_0_f64(double addrspace(1)* %out, double addrspace(1)* %aptr, double addrspace(1)* %bptr, double addrspace(1)* %cptr) #0 {
----------------
fmin isn't impacted by this change, but this doesn't hurt

================
Comment at: test/CodeGen/AMDGPU/min3.ll:161

+; GCN-LABEL: {{^}}v_test_imin3_slt_i8:
+; SI: v_min3_i32
----------------
Max coverage would also be good, not just min

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59543/new/

https://reviews.llvm.org/D59543