[PATCH] D59543: [AMDGPU] Ban i8 min3 promotion.

Neil Henning via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 07:26:35 PDT 2019


sheredom marked 2 inline comments as done.
sheredom added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:8137
   if (Opc != AMDGPUISD::FMIN_LEGACY && Opc != AMDGPUISD::FMAX_LEGACY &&
-      !VT.isVector() && VT != MVT::f64 &&
+      !VT.isVector() && VT != MVT::f64 && VT != MVT::i8 &&
       ((VT != MVT::f16 && VT != MVT::i16) || Subtarget->hasMin3Max3_16())) {
----------------
arsenm wrote:
> It seems like blacklisting specific MVTs won't work
Good idea, changed it to a whitelist!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59543/new/

https://reviews.llvm.org/D59543





More information about the llvm-commits mailing list