[PATCH] D59519: [WebAssembly] Lower SIMD nnan setcc nodes

[Thomas Lively via Phabricator via llvm-commits]

tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:422
+// target-independent expansion of unordered comparisons and ordered ne.
+foreach nodes = [[seteq, EQ_v4f32], [setne, NE_v4f32], [setlt, LT_v4f32],
+                 [setgt, GT_v4f32], [setle, LE_v4f32], [setge, GE_v4f32]] in
----------------
dschuff wrote:
> do we also need ord? I guess ord would trivially be true since they are nnan? Anyway, not sure how exactly the dag nodes line up with the LLVM IR ones, but let's jsut make sure we aren't missing more while we're at it.
I have tests for `ord nnan` and `uno nnan` below. They apparently do no become no-ops, but are expanded the same as `ord`and `uno` with NaNs allowed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59519/new/

https://reviews.llvm.org/D59519