[PATCH] D59462: [WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG

[Alon Zakai via Phabricator via llvm-commits]

kripken added a comment.

Nice idea, and overall looks good to me. I didn't quite understand the TII part though.

Btw, are there no backend passes that would do this optimization anyhow (merge identical branches)?



================
Comment at: lib/Target/WebAssembly/WebAssemblyFixIrreducibleControlFlow.cpp:390
+  // This map stores whether this predecessor is within this loop.
+  DenseMap<MachineBasicBlock *, bool> InLoop;
+  for (auto *Pred : AllPreds) {
----------------
What is the advantage of a map to bool over a set?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59462/new/

https://reviews.llvm.org/D59462