[PATCH] D58957: [AMDGPU] Add an experimental buffer fat pointer address space.

[Neil Henning via Phabricator via llvm-commits]

sheredom marked 10 inline comments as done.
sheredom added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:65
+  /* Private  */        {MayAlias, NoAlias , NoAlias , NoAlias , NoAlias , MayAlias, NoAlias ,        NoAlias},
+  /* Constant 32-bit */ {MayAlias, MayAlias, MayAlias, NoAlias , MayAlias, NoAlias , NoAlias ,        MayAlias},
+  /* Buffer Fat Ptr  */ {MayAlias, MayAlias, NoAlias , NoAlias , MayAlias, NoAlias , MayAlias,        MayAlias}
----------------
arsenm wrote:
> nhaehnle wrote:
> > sheredom wrote:
> > > nhaehnle wrote:
> > > > It may be more pragmatic to have NoAlias with Constant 32-bit.
> > > > 
> > > > The intention and current practice is for Constant 32-bit to be used with descriptor tables, and those really shouldn't ever alias buffer fat pointers. 
> > > Should I then actually be changing all the Constant 32-bit aliasing rules to only alias with itself do you think?
> > I think that's a good idea, but it should be a separate patch.
> It also seems to me like it should be renamed, since there's a more specific purpose in mind than just a 32-bit pointer for constant
Agreed on both your comments, I'll submit that change as a separate patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58957/new/

https://reviews.llvm.org/D58957