[PATCH] D59357: [RISCV] Add codegen support for ilp32f, ilp32d, lp64f, and lp64d ("hard float") ABIs

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added a comment.
Herald added subscribers: benna, psnobl.

Thanks a lot for this Alex.

Looks good to me. I only have a minor comment about testing varargs for hard-float ABIs as well.



================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:986-987
+  case RISCVABI::ABI_LP64D:
+    UseGPRForF32 = !IsFixed;
+    UseGPRForF64 = !IsFixed;
+    break;
----------------
Using `IsFixed` here adds a new path that we may want to have covered as well.

I think this can be achieved by adding a call to a varargs function passing several `double` arguments in test files `calling-conv-ilp32-ilp32f-ilp32d-common.ll` and `calling-conv-lp64-lp64f-lp64d-common.ll`.

What do you think?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59357/new/

https://reviews.llvm.org/D59357